Fix sweep node wallets job to return errors without clear reason - #580
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves observability for SweepNodeWalletsJob by ensuring the job logs a non-empty, actionable reason when it decides not to fund/broadcast a sweep transaction—addressing production error traces where {Reason} was previously empty.
Changes:
- Replaces an inline nested-conditional “reason” builder with a dedicated helper method.
- Adds a default/fallback reason message for the previously-unhandled “below sweep threshold” case, preventing empty
{Reason}logs.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RodriFS
reviewed
Aug 26, 2026
imclvr
force-pushed
the
fix/fix-sweep-node-wallets-error-without-reason
branch
from
August 27, 2026 07:07
9edac1c to
2385ea3
Compare
RodriFS
approved these changes
Aug 27, 2026
imclvr
force-pushed
the
fix/fix-sweep-node-wallets-error-without-reason
branch
from
August 27, 2026 08:23
2385ea3 to
cd124ba
Compare
imclvr
enabled auto-merge
August 27, 2026 08:23
markettes
pushed a commit
that referenced
this pull request
Aug 28, 2026
…-without-reason Fix sweep node wallets job to return errors without clear reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There're many error traces in prod without a clear reason. After looking at the code, looks like we were missing one particular case which seems to be a quite frequent one.